Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify docs arugment #90

Closed
timotheemoulin opened this issue Mar 12, 2020 · 5 comments
Closed

Clarify docs arugment #90

timotheemoulin opened this issue Mar 12, 2020 · 5 comments

Comments

@timotheemoulin
Copy link

Can we update the example in the doc and add one with the full locale? I think that could help.

e.g.

wp language core install fr_FR

or at least write something in the options section under the <language> chapter.

@danielbachhuber
Copy link
Member

@timotheemoulin I'm not sure I understand your suggestion... want to submit a pull request with your suggested change?

@ernilambar
Copy link
Member

@danielbachhuber

Let me jot down my understanding here.

https://developer.wordpress.org/cli/commands/language/core/install/ - wp language core install <language>... [--activate]

<language> - Language code to install.

We have mentioned language code. But in our WordPress context, Language Code is different than WordPress Locale Code.

For Nepali language, language code is ne but WP locale code is ne_NP.
But some languages have same language code and locale code like ja, ar, etc.

In our docs, it is not particularly clear that we should use ne_NP instead of ne. In the example also, we have used Japanese which coincidently happens to have same language code and locale code.
So I believe OP is asking to clarify this confusion in the docs and examples.

@danielbachhuber danielbachhuber changed the title Change doc example Clarify docs arugment Jun 7, 2024
@danielbachhuber
Copy link
Member

@ernilambar Thanks for clarifying — that makes sense!

@UmeshSingla
Copy link
Contributor

Working on it.

@swissspidy
Copy link
Member

Fixed by #153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants