Add missing filesystem function exclsuions #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Argh, duplicate of #177 ... |
Merged
swissspidy
approved these changes
Aug 30, 2023
jrfnl
reviewed
Aug 30, 2023
Comment on lines
+82
to
+98
| <exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_chgrp" /> | ||
| <exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_chmod" /> | ||
| <exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_chown" /> | ||
| <exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_fclose" /> | ||
| <exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_file_put_contents" /> | ||
| <exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_fopen" /> | ||
| <exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_fputs" /> | ||
| <exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_fread" /> | ||
| <exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_fsockopen" /> | ||
| <exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_fwrite" /> | ||
| <exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_is_writable" /> | ||
| <exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_is_writeable" /> | ||
| <exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_mkdir" /> | ||
| <exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_pfsockopen" /> | ||
| <exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_readfile" /> | ||
| <exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_rmdir" /> | ||
| <exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_touch" /> |
There was a problem hiding this comment.
This whole list should be removed (maintenance overhead) as the exclude for file_system_operations on line 148 does the exact same thing already (just more efficiently).
There was a problem hiding this comment.
Thanks, good to know.
Fixing in #177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the custom PHPCS ruleset to exclude all current filesystem functions to the list of exclusions.