Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing filesystem function exclsuions #178

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Add missing filesystem function exclsuions #178

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dddcd5f
Add missing filesystem function exclsuions
schlessera Aug 30, 2023
6f236cb
Fix group name change
schlessera Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion WP_CLI_CS/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,23 @@
<exclude name="Universal.Operators.DisallowShortTernary.Found"/>

<!-- Allow filesystem operations because WordPress APIs may not be available -->
<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_chgrp" />
<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_chmod" />
<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_chown" />
<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_fclose" />
<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_file_put_contents" />
<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_fopen" />
<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_fputs" />
<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_fread" />
<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_fsockopen" />
<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_fwrite" />
<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_is_writable" />
<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_is_writeable" />
<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_mkdir" />
<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_pfsockopen" />
<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_readfile" />
<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_rmdir" />
<exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_touch" />
Comment on lines +82 to +98
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole list should be removed (maintenance overhead) as the exclude for file_system_operations on line 148 does the exact same thing already (just more efficiently).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good to know.

Fixing in #177

<exclude name="WordPress.WP.AlternativeFunctions.rename_rename" />
<exclude name="WordPress.WP.AlternativeFunctions.unlink_unlink" />

Expand Down Expand Up @@ -131,7 +145,7 @@
<property name="exclude" type="array">
<element value="curl"/>
<element value="file_get_contents"/>
<element value="file_system_read"/>
<element value="file_system_operations"/>
<!-- As PHP 5.4. is the minimum for most projects, using json_encode() is fine. -->
<element value="json_encode"/>
</property>
Expand Down