-
Notifications
You must be signed in to change notification settings - Fork 216
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undefined index: in plugins/wp-e-commerce/wpsc-includes/cart.class.php on line 432 #1683
Comments
I can reproduce this if a shipping method is enabled, and then the plugin providing that rate is disabled without the method being de-selected first. xdebug trace below. Notice: Undefined index: ses_wpsc_premium_shipping in /var/www/wpec38/wp-content/plugins/wp-e-commerce/wpsc-includes/cart.class.php on line 432 Time Memory Function Location1 0.0004 132772 {main}( ) ../plugins.php:0 |
Actually, scrap that, that doesn't seem to be the issue. I re-activated the plugin providing that method, and ensured it was de-selected in WP e-Commerce settings, then deactivated the plugin again and I still get this warning. Will try and debug further later on today. |
I agree that that commit is the cause, we're trying to access $wpsc_shipping_modules[$this->selected_shipping_method] when that's undefined (So I guess that the user's session has a selected option that is no longer avalable). Looking at that function, I think there's a bunch of cleaning up we can do that's "better" than just reverting that commit though. Will raise a PR tonight |
I just setup a brand new WordPress and WP eCommerce from wp.org repo (3.9). Added the fix here: And now i`m getting this:
|
@misulicus Followed your instructions exactly, and was unable to replicate. Can you confirm that this still occurs in master, and which line the notice is referencing now? |
setup a new store with 3.9 and master.no more error so far |
Great, thanks for the confirmation. |
Ok this is really weird. the ajax request shows these issues with debug ON:
|
right above that line i tried to debug:
|
i did a database search for 'shipping' Removed the _wpsc_cart.shipping_method_count field and no more error. |
Have had a couple reports of this, but not yet able to replicate. I'm sure it's from this commit, but I'm hesitant to revert without a clear path to reproduce.
The text was updated successfully, but these errors were encountered: