-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't download products in 3.8.9.4 #37
Comments
The blog comment seems to be a totally different issue (one that I myself couldn't reproduce). As for this issue, we haven't modified any file ID verification code in 3.8.9.x. If you look at this, you'll see that nothing changes in the way we verify file ID: Is there a limit of number of downloads for that product file? Check Settings->Admin and you'll see the "Max downloads per file" field, which defaults to 1. Which means if that file has been downloaded before, it will expire. |
It's a 3.8.8.5 or earlier bug, it just has surfaced in testing of 3.8.9.x. It is due to us linking to the Download File ID of a Product which becomes invalid when a store owner removes or changes the File Downloads for that Product (e.g. change of Plugin file versions, etc.). When a customer purchases a Product they should get the File Downloads associated with that Product regardless of when they purchased it (I purchased ABC until my download number expires, not ABC v1.1 until the Product is updated). |
Ahh, I understand - that makes more sense than the original report. If this is something that has always been an issue in the 3.8.9 branch, I'm inclined to defer this to 3.8.10, as it's not really a regression due to a prior maintenance release, just a bug. An annoying one, to be sure. |
If I'm good remember this one persist since I remember, 3.7.5?! After purchase download links are generated for user but they are not updated within product update. (I can be wrong, didn't investigate it) |
There doesn't seem to be a lot of urgent request for this to be fixed in the support forums so I'm inclined to say this should be dealt with in 3.8.10. |
Agreed |
I think there should be a it off a debate about how this should work. For example some store owners might not want people to get updated version of the files - they may want people just to get the version they purchased? |
Yeah, I see your point, there's room for it to work both ways, for sure. I'd like to avoid adding more options though. Maybe we could ping @pippinsplugins and see what format people tend to use EDD in most and default to that, having an filter in place to have it work the other way? I suppose my assumption would be that most would operate like the App Store - purchase once, updates forever (or for some length of time, at least.) But once we get into discussing that model, we start into a completely separate enhancement ticket :) |
Based on a quick bit of testing, EDD works as follows:
I'd argue that that behaviour is broken as well since customer 1 should always be able to get file A since that's what they purchased? |
Hey everybody. Happy new year!!! My thoughts on digital downloads are as follows;
(when we very first built digital download capabilities into WPEC this is the way that it used to work)
I also think that digital download access should be something that can be restricted / integrated with recurring billing. Lots of people sell annual subscriptions to digital downloads and I don't think WPEC should be any different. We probably need better versioning control in general. We can take further pointers from Pippin :) Best, On 30/12/2012, at 3:53 AM, leewillis77 notifications@github.com wrote:
|
Hi Dan, agreed on point 1, point 2 as an extension for WP e-Commerce (keep core lean). |
Yeah, I think Dan's spot on with this one and how it should work. And to be honest, with the amount of new work @lukecarbis has put into the new User page - I wouldn't necessarily consider point #2 to be core bloat, it seems like a nice core piece of functionality to improve how this works. That said - it sounds like this feature doesn't have a ton of traction (where several others do), so I'm considering punting to 3.9 pending a pull request. |
Like Dan, I think the default functionality should be if a product download is updated, existing users can access the updated files. This is the way I thought it actually worked. However, I do agree with Lee that if someone has bought a product, if feels like they should have access to the exact thing they bought - that is what they paid for after all! That would involve some sort of versioning I guess. However, at the same time, if I uploaded a file to a product, realised I had made a mistake and uploaded a replacement, I wouldn't want a customer to have access a history of all files I had uploaded. Just a few things to think about... |
I'm moving this to 3.9 as there has been no concrete solutions yet, and no-one has been assigned. |
Hey :) And it happened that now there is no link, it has been deleted. I'm surprised it works that way, i thought it was something available in this plugin. Have a good day everyone and thank you for all your work :) |
Hey guys, I just happen to test this feature in 3.9. I did a test of creating a downloadable product. Did a purchase, then click on "Your account" page. The page tells me that "You have not purchased any downloadable products yet." |
@instinct-ray can't replicate. |
Scratch my comment, Once I mark the payment as accepted payment, I can see my downloads! |
To reproduce this issue Ray you need to now open up Edit Product for that Product you purchased (and can now download electronic downloads from) and upload a new electronic file against that Product. Then save changes to the Product. Open My Account with the User that has permission to download that Product's electronic downloads then try to download the new electronic file. |
Indeed, the original issue still persists. Was just confirming that @instinct-ray's issue was not a regression in 3.9. |
…wnloads(), rather than a single file. Also introduces wpsc_has_downloads filter. See #37.
Edited: From Visser's comment below which provides more details:
It is due to us linking to the Download File ID of a Product which becomes invalid when a store owner removes or changes the File Downloads for that Product (e.g. change of Plugin file versions, etc.).
When a customer purchases a Product they should get the File Downloads associated with that Product regardless of when they purchased it (I purchased ABC until my download number expires, not ABC v1.1 until the Product is updated).
The text was updated successfully, but these errors were encountered: