Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up PHPStan configuration #1794

Merged
merged 4 commits into from
Mar 19, 2021
Merged

Clean up PHPStan configuration #1794

merged 4 commits into from
Mar 19, 2021

Conversation

szepeviktor
Copy link
Contributor

Mainly the unescaped pipe sign!

@szepeviktor
Copy link
Contributor Author

I can barely accept this regexp forest 🌲🌲🌲🌲🌲
Working on a zero-ignores solution...

@szepeviktor
Copy link
Contributor Author

@jasonbahl The work took so long I've got hungry. Please send me an 🥑 sandwich!

@szepeviktor szepeviktor changed the title Fix regexp-s in PHPStan configuration Clean up PHPStan configuration Mar 19, 2021
@coveralls
Copy link

coveralls commented Mar 19, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 79.377% when pulling 4b627a3 on szepeviktor:patch-1 into c1dde50 on wp-graphql:develop.

jasonbahl
jasonbahl approved these changes Mar 19, 2021
View reviewed changes
Copy link
Collaborator

@jasonbahl jasonbahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Thanks so much for making this codebase better! Really appreciate the details like this!

@jasonbahl jasonbahl merged commit 9c4aab2 into wp-graphql:develop Mar 19, 2021
@jasonbahl jasonbahl mentioned this pull request Mar 19, 2021
Merged
@szepeviktor szepeviktor deleted the patch-1 branch March 20, 2021 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonbahl jasonbahl jasonbahl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szepeviktor @coveralls @jasonbahl