#1827 - Term connection order issues #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add "order" enum to Term Connection Queries - Add a test case to make sure the query with order is valid and returns
jasonbahl
added
type: bug
- Add CursorPaginationForCategoriesTest
- Remove check for `before` argument in TermObjectConnectionResolver when flipping the ASC/DESC args - Update TermObjectCursor to handle ASC/DESC order based on the compare direction
- Code formatting adjustments - Remove commented code from refactoring to add Cursor support to term connections - Update yoda conditional
jasonbahl
added
component: connections
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This adds an
orderfield to Term Connection Queries allowing the queries to set an order of ASC or DESC.Users can now query like so:
{ categories( where: { orderby: COUNT order: ASC} ) { nodes { id databaseId name count } } }Does this close any currently open issues?
Closes #1827
Any other comments?
Post Connections support orderby as an array of field/order like below:
The WP_Term_Query only supports a single input for
orderandorderbyand WPGraphQL maps to WP_Term_Query, so only a singleorderandorderbyare supported, not a list of fields with their own cardinality.