Bugfix: Remove non-null from MenuItem path #1865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From Wordpress it is possible to add a custom link without an URL. When that happens GraphQL will throw `Cannot return null for non-nullable field \"MenuItem.path\".`.
furedal
changed the title
jasonbahl
reviewed
Apr 30, 2021
jasonbahl
approved these changes
Jul 1, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Wordpress it is possible to add a custom link without an URL.
When that happens GraphQL will throw
Cannot return null for non-nullable field \"MenuItem.path\"..What does this implement/fix? Explain your changes.
From Wordpress it is possible to add a custom link without an URL.
When that happens GraphQL will throw
Cannot return null for non-nullable field \"MenuItem.path\"..Does this close any currently open issues?
Any relevant logs, error output, GraphiQL screenshots, etc?
Cannot return null for non-nullable field "MenuItem.path".
Any other comments?
Where has this been tested?
**Operating System: Linux
**WordPress Version: 5.7.1