Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR changes the stalebot configuration to no longer automatically close issues, preventing the quarterly "stalepocalypse", where dozens of issues are unceremoniously closed, flooding maintainers with a deluge of notifications, and forcing them to comb through them all or risk them being swept under the rug for good.
Once merged, the following changes to the "triage flow" will take effect:
stale
label will be deleted and replaced bystale?
on existing issues. (manual task: assigned to @justlevine )stale?
.stale?
issue will automatically remove thestale?
label.stale?
issues by removing thestale?
label manually, closing asinvalid
orwontfix
, or progressing the issue until it earns one of theexemptLabels
(e.g.ready for review
,status: blocked
, etc). Note: thenot stale
label should be reserved for long-term milestones or evergreen issues that are unlikely to be invalidated by a separate issue/PR, and not just to short-circuit the stalebot checks.stale?
label by filtering the issue tracker / project.Does this close any currently open issues?
Revisits #2494
Any relevant logs, error output, GraphiQL screenshots, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Any other comments?
The argument in a nutshell is:
Premises:
1: There are so many issues in the backlog, it makes triage and prioritization a nightmare.
2: Many issues are low-priority
wontfix
-es that can only be implemented if someone decides to prioritize the work on it.3: We have limited resources (contributor hours) both in terms of issue triage and exploring/submitting actual PRs.
Arguments for autoclosing:
Arguments against:
stale?
andstale
, and thenot stale
label can itself go stale, so its only use is for shortcircuiting the check, and there's semantic statuses that are better suited to it if we dont need to worry about the issue getting closed and dissappearing).stale?
label from the issue/project view.Where has this been tested?
Operating System: N/A
WordPress Version: N/A