Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Decode slug so it works with other languages #2940

Merged
merged 6 commits into from
Oct 10, 2023
Merged

fix: Decode slug so it works with other languages #2940

merged 6 commits into from
Oct 10, 2023

Conversation

scottyzen
Copy link
Contributor

@scottyzen scottyzen commented Sep 26, 2023 •
edited
Loading

fix: Decode strings so it works with other languages

What does this implement/fix? Explain your changes.

  • Decodes the slug so it works with other languages. Like Hebrew, Arabic, etc.
  • Decodes the type name, so it works with different languages (e.g. Chinese, Hebrew, etc.)

##Example:

  • Before: "%d7%90%d7%91%d7%99%d7%96%d7%a8%d7%99%d7%9d"
  • After: "הטבה לרוכשים"

Where has this been tested?

WordPress Version: 6.3.1

@jasonbahl jasonbahl added the needs: reviewer response This needs the attention of a codeowner or maintainer label Sep 27, 2023
@justlevine justlevine added the needs: tests Tests should be added to be sure this works as expected label Sep 28, 2023
@coveralls
Copy link

Coverage Status

coverage: 84.726% (+0.002%) from 84.724% when pulling 2b3177d on scottyzen:fix/slug-not-returning-correctly into 2937585 on wp-graphql:develop.

@justlevine justlevine removed the needs: tests Tests should be added to be sure this works as expected label Oct 3, 2023
@codeclimate
Copy link

codeclimate bot commented Oct 3, 2023

Code Climate has analyzed commit 4540fc2 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

View more on Code Climate.

@justlevine justlevine added type: bug Issue that causes incorrect or unexpected behavior status: in review Awaiting review before merging or closing scope: i18n Internationalizing, translating, and localizing labels Oct 3, 2023
@justlevine
Copy link
Collaborator

Tests added and ready for final review / merge. @jasonbahl @josephfusco

@justlevine justlevine self-requested a review October 3, 2023 23:18
@jasonbahl jasonbahl merged commit 4ecbdae into wp-graphql:develop Oct 10, 2023
26 of 27 checks passed
@jasonbahl jasonbahl mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate CodeClimate codeclimate left review comments

@jasonbahl jasonbahl jasonbahl approved these changes

@justlevine justlevine justlevine approved these changes

@josephfusco josephfusco Awaiting requested review from josephfusco

Assignees
No one assigned
Labels
needs: reviewer response This needs the attention of a codeowner or maintainer scope: i18n Internationalizing, translating, and localizing status: in review Awaiting review before merging or closing type: bug Issue that causes incorrect or unexpected behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scottyzen @coveralls @justlevine @jasonbahl