perf: refactor PluginConnectionResolver
to only fetch plugins once
#3084
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR refactors our
PluginConnectionResolver
class to use a DRY::get_all_plugins()
method for building the list of available plugins.This list is then stored in a class property, so the fetching, filtering, etc only occur once.
Does this close any currently open issues?
Any relevant logs, error output, GraphiQL screenshots, etc?
Part of #2749
Any other comments?
This PR is based on #3082 , which should be merged first.
Where has this been tested?
Operating System: Ubuntu 20.04 (wsl2 + devilbox + php 8.1.15)
WordPress Version: 6.4.3