chore: connection resolvers cleanup #3101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling refactor: improve `loader` handling in `AbstractConnectionResolver`
…t_query_amount feat: improve query amount handling in `AbstractConnectionResolver`
…red_args refactor: add `AbstractConnectionResolver::get_unfiltered_args()` public getter
refactor: add `AbstractConnectionResolver::prepare_page_info()`and only instantiate once
…backport/deprecate-camelcased # Conflicts: # src/Data/Connection/AbstractConnectionResolver.php
…amelcased refactor: deprecate `camelCase` methods in `AbstractConnectionResolver` for `snake_case` equivalents
|
Code Climate has analyzed commit f7309af and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| * | ||
| * @throws \Exception | ||
| */ | ||
| public function get_loader_name() { |
There was a problem hiding this comment.
Function get_loader_name has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This pulls together changes from the following PRs into one PR to the
developbranch:camelCasemethods inAbstractConnectionResolverforsnake_caseequivalents #3083AbstractConnectionResolver::prepare_page_info()and only instantiate once #3085AbstractConnectionResolver::get_unfiltered_args()public getter #3086AbstractConnectionResolver#3087loaderhandling inAbstractConnectionResolver#3088PluginConnectionResolverto only fetch plugins once #3084Does this close any currently open issues?
Any relevant logs, error output, GraphiQL screenshots, etc?
Any other comments?
Related: #2749
Related: #2715
Related: #2678
Related: #1588
Where has this been tested?
Operating System: …
WordPress Version: …