fix: WPGraphQL Settings page fails to load when "graphiql_enabled" setting is "off" #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hiql_link_in_admin_bar" settings and how they impact the settings page
josephfusco
previously approved these changes
May 21, 2024
- replace it with e2e playwright test
|
Code Climate has analyzed commit f79051b and detected 0 issues on this pull request. View more on Code Climate. |
josephfusco
approved these changes
May 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This fixes a bug where the WPGraphQL Settings page would fail to load after the "Enable GraphiQL IDE" setting is set to "off".
Does this close any currently open issues?
closes #3136
Any other comments?
When setting the "Enable GraphiQL IDE" setting to "off" and saving the settings:
Before
The settings page fails to load and a console error is displayed.
After
Now the settings page loads as expected, but the IDE is disabled, also as expected.