Fix error message for non-existent post #501
Merged
+56
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Fixes a grammatical error in an error message that has been bugging me for a long time. 😂
It's worth noting that this is actually a breaking change for us! This error corresponds to a 404 response for us on the client. But because this is a error and not an empty response, we have to catch all errors and inspect them in order to determine whether we should 404. The only way to do this is to regex the string, making it a bit fragile.
Have we considered implementing error codes (either on the error object or leading the message)?
Any other comments?
Added test, which would at least catch future changes to the message.