Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v0.0.34 #530

Merged
merged 45 commits into from Sep 27, 2018
Merged

Release/v0.0.34 #530

merged 45 commits into from Sep 27, 2018

Conversation

jasonbahl
Copy link
Collaborator

Release Notes

Issues Closed

Docker Revamp (#462)

We were having issues with our Code Coverage reports since switching our testing to a Docker environment.

This release introduces a new Docker setup that effectively runs tests with coverage and utilizes CodeCov for coverage reports. Thanks @mngi-arogers for work on this!

jasonbahl and others added 30 commits August 17, 2018 09:38
- update version number and misc file formatting
…perly.

Since batch requests come in as an array, we need to iterate over the array and send out the do_graphql_request action for each

#496 - PHP Warnings are being thrown because we sometimes try to use $source->ID even if the $source is a Term and has no ->ID property.
Fix error message for non-existent post
…t_object() to make sure the global $post is properly setup and setup_postdata is properly run. This ensures filters that rely on that to run properly.
#504 - Ensure post objects are resolved using DataSource::resolve_pos…
ISSUE-507 map tagIn->tag__in
@codecov
Copy link

codecov bot commented Sep 27, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@a03c17e). Click here to learn what that means.
The diff coverage is 51.58%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #530   +/-   ##
=========================================
  Coverage          ?   66.68%           
=========================================
  Files             ?      103           
  Lines             ?     6529           
  Branches          ?        0           
=========================================
  Hits              ?     4354           
  Misses            ?     2175           
  Partials          ?        0
Impacted Files Coverage Δ
src/Router.php 12.39% <0%> (ø)
...Object/Connection/PostObjectConnectionResolver.php 69.49% <0%> (ø)
src/Type/PostObject/Mutation/PostObjectDelete.php 69.81% <100%> (ø)
src/Type/PostObject/PostObjectType.php 71.34% <100%> (ø)
src/Type/Comment/CommentType.php 68.46% <100%> (ø)
src/Data/DataSource.php 83.85% <100%> (ø)
...Object/Connection/TermObjectConnectionResolver.php 67.36% <100%> (ø)
src/Type/PostObject/Mutation/PostObjectUpdate.php 70% <100%> (ø)
src/Type/PostObject/Mutation/PostObjectCreate.php 65.45% <100%> (ø)
src/Type/MediaItem/Mutation/MediaItemDelete.php 72.22% <100%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a03c17e...0dd47b7. Read the comment docs.

@jasonbahl jasonbahl requested review from hughdevore, chriszarate and CodeProKid and removed request for chriszarate September 27, 2018 18:58
@jasonbahl jasonbahl self-assigned this Sep 27, 2018
Copy link
Contributor

@hughdevore hughdevore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔎 🚢

@hughdevore hughdevore merged commit feaf091 into master Sep 27, 2018
@jasonbahl jasonbahl deleted the release/v0.0.34 branch December 8, 2018 05:00
@jasonbahl jasonbahl restored the release/v0.0.34 branch May 23, 2019 20:52
@jasonbahl jasonbahl deleted the release/v0.0.34 branch August 16, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants