Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faust Auth doesn't seem to work when using Safari #1700

Closed
1 of 2 tasks
ChrisWiegman opened this issue Dec 29, 2023 · 4 comments
Closed
1 of 2 tasks

Faust Auth doesn't seem to work when using Safari #1700

ChrisWiegman opened this issue Dec 29, 2023 · 4 comments
Assignees
Labels
type: bug Issue that causes incorrect or unexpected behavior

Comments

@ChrisWiegman
Copy link
Contributor

ChrisWiegman commented Dec 29, 2023

Steps to Reproduce

  • Start the example app
  • Ensure your headless secret key is set properly
  • Preview a post
  • Notice that the headless refresh token isn’t saved as a cookie

Expected Behavior

- Auth saves cookie and authenticated content can be fetched.
- Toolbar should work as expected
- Post previews should work as expected

Technical Details

This is how Safari works.

See: #1558 (comment)

Acceptance Criteria

  • Document this as a known limitation/issue with Safari over localhost
  • Consider ways to surface this within the Faust plugin when the appropriate conditions exist
@ChrisWiegman ChrisWiegman added the type: bug Issue that causes incorrect or unexpected behavior label Dec 29, 2023
@jordanmaslyn
Copy link
Contributor

Is this related to #1558?

@mindctrl
Copy link
Contributor

mindctrl commented Jan 5, 2024

@jordanmaslyn yes. We're going to document Safari's behavior in our docs and look into ways to communicate this in the plugin somewhere when using Safari over http. This was copy/pasted from Jira. We've since had a chat about the limitation and our approach. I'll update the AC in the OP.

@theodesp theodesp self-assigned this Jan 5, 2024
@theodesp
Copy link
Member

theodesp commented Jan 8, 2024

@mindctrl
Copy link
Contributor

mindctrl commented Jan 9, 2024

Yesterday we decided that documentation is enough for now. We don't want to add any more UI to the plugin, unless this turns into a bigger problem for those users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issue that causes incorrect or unexpected behavior
Projects
None yet
Development

No branches or pull requests

4 participants