Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WPIMath JNI usage #303

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

calcmogul
Copy link
Member

No description provided.

@KangarooKoala
Copy link

Just to confirm, none of the other JNI classes (ArmFeedforwardJNI, DAREJNI, EigenJNI, Ellipse2dJNI, Pose3d, and StateSpaceJNI) are transitively loaded by PathWeaver, right?

@PeterJohnson PeterJohnson merged commit 0626766 into wpilibsuite:main Jun 8, 2024
7 checks passed
@calcmogul calcmogul deleted the update-wpimath-jni-usage branch June 8, 2024 19:00
@calcmogul
Copy link
Member Author

PathWeaver uses the following WPIMath classes:

[tav@myriad PathWeaver]$ rg edu.wpi.first.math
src/main/java/edu/wpi/first/pathweaver/PathWeaver.java
3:import edu.wpi.first.math.jni.TrajectoryUtilJNI;

src/main/java/edu/wpi/first/pathweaver/spline/wpilib/WpilibSpline.java
3:import edu.wpi.first.math.geometry.Pose2d;
4:import edu.wpi.first.math.kinematics.DifferentialDriveKinematics;
5:import edu.wpi.first.math.spline.PoseWithCurvature;
6:import edu.wpi.first.math.spline.QuinticHermiteSpline;
7:import edu.wpi.first.math.spline.Spline;
8:import edu.wpi.first.math.trajectory.Trajectory;
9:import edu.wpi.first.math.trajectory.TrajectoryConfig;
10:import edu.wpi.first.math.trajectory.TrajectoryGenerator;
11:import edu.wpi.first.math.trajectory.TrajectoryUtil;

Of these, only TrajectoryUtil uses a JNI class: TrajectoryUtilJNI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants