[wpimath] Report error when x and y components of Rotation2d are both…

… zero (#6767) Fixes #6766.
wpilibsuite · Jul 8, 2024 · 7f6ba54 · 7f6ba54
1 parent 3d22eec
commit 7f6ba54
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/wpimath/src/main/java/edu/wpi/first/math/geometry/Rotation2d.java b/wpimath/src/main/java/edu/wpi/first/math/geometry/Rotation2d.java
@@ -10,6 +10,7 @@
 import com.fasterxml.jackson.annotation.JsonCreator;
 import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
 import com.fasterxml.jackson.annotation.JsonProperty;
+import edu.wpi.first.math.MathSharedStore;
 import edu.wpi.first.math.MathUtil;
 import edu.wpi.first.math.geometry.proto.Rotation2dProto;
 import edu.wpi.first.math.geometry.struct.Rotation2dStruct;
@@ -118,6 +119,8 @@ public Rotation2d(double x, double y) {
     } else {
       m_sin = 0.0;
       m_cos = 1.0;
+      MathSharedStore.reportError(
+          "x and y components of Rotation2d are zero\n", Thread.currentThread().getStackTrace());
     }
     m_value = Math.atan2(m_sin, m_cos);
   }

diff --git a/wpimath/src/main/native/include/frc/geometry/Rotation2d.inc b/wpimath/src/main/native/include/frc/geometry/Rotation2d.inc
@@ -4,10 +4,15 @@
 
 #pragma once
 
+#include <string>
+#include <type_traits>
+
 #include <gcem.hpp>
+#include <wpi/StackTrace.h>
 
 #include "frc/geometry/Rotation2d.h"
 #include "units/angle.h"
+#include "wpimath/MathShared.h"
 
 namespace frc {
 
@@ -24,6 +29,11 @@ constexpr Rotation2d::Rotation2d(double x, double y) {
   } else {
     m_sin = 0.0;
     m_cos = 1.0;
+    if (!std::is_constant_evaluated()) {
+      wpi::math::MathSharedStore::ReportError(
+          "x and y components of Rotation2d are zero\n{}",
+          wpi::GetStackTrace(1));
+    }
   }
   m_value = units::radian_t{gcem::atan2(m_sin, m_cos)};
 }