Template motion profile units #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcmogul
reviewed
Nov 20, 2019
wpilibc/src/main/native/include/frc/trajectory/TrapezoidProfile.h
Outdated
Show resolved
Hide resolved
calcmogul
previously approved these changes
Nov 20, 2019
wpilibc/src/main/native/include/frc/trajectory/TrapezoidProfile.h
Outdated
Show resolved
Hide resolved
PeterJohnson
approved these changes
Nov 21, 2019
pjbuterbaugh
pushed a commit
to pjbuterbaugh/allwpilib
that referenced
this pull request
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Templates the distance units for
TrapezoidProfileandProfiledPIDController.PIDControlleris left untemplated - I do not think it is a good idea to template it unless we go whole-hog and template both the input and the output units, which means the gains would have to be dimensioned, which would probably impede usability for novice programmers quite a bit.