Fix tile titles #198
Merged
Fix tile titles #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the source will change the title, but changing the title no longer affects the source name
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
============================================
- Coverage 15.12% 15.05% -0.08%
Complexity 241 241
============================================
Files 149 150 +1
Lines 3834 3853 +19
Branches 290 290
============================================
Hits 580 580
- Misses 3223 3242 +19
Partials 31 31 |
nightpool
reviewed
Sep 21, 2017
| @@ -48,7 +48,6 @@ public EditableLabel() { | |||
| if (isEditing) { | |||
| editField.requestFocus(); | |||
| } | |||
| label.setVisible(!isEditing); | |||
There was a problem hiding this comment.
The visible property is already bound so all this does is throw an exception
nightpool
reviewed
Sep 28, 2017
| log.log(Level.SEVERE, "Could not get the tab containing the widget pane!", e); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
from discussion: let's leave this off for now until we can refactor auto-population
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the text overrun to the left side to make titles look like
...system/Victor/Speedinstead of/LiveWindow/MySub...Uses the tab source prefix to remove redundant leading information
Changing the widget title no longer changes the name of its source
Fixes #29