Skip to content
This repository has been archived by the owner on Oct 1, 2023. It is now read-only.

Separate forward/backward plots #353

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

Oblarg
Copy link
Contributor

@Oblarg Oblarg commented Feb 2, 2022

Also fixes a minor crash bug involving attempting to refresh the plots when no data are available.

@Oblarg Oblarg force-pushed the separate-forward-backward-plots branch from 42df73a to 193921e Compare February 2, 2022 21:01
@Oblarg
Copy link
Contributor Author

Oblarg commented Feb 2, 2022

image

@Oblarg Oblarg force-pushed the separate-forward-backward-plots branch from 193921e to 3fdb8bc Compare February 2, 2022 21:20
Copy link
Member

@calcmogul calcmogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I load a JSON, then click the analysis reset button, then try to choose "backward" in the direction combo box, it crashes. m_hasData isn't being set back to false when it should.

Also, how does that flag differ from m_enabled?

@calcmogul
Copy link
Member

calcmogul commented Feb 3, 2022

We should look into refactoring the error handling at some point. We're approximating a state machine of some kind, but it's not formally defined, and we may not be handling all error conditions properly.

@calcmogul calcmogul linked an issue Feb 3, 2022 that may be closed by this pull request
@calcmogul calcmogul requested a review from Piphi5 February 3, 2022 02:29
@calcmogul calcmogul changed the title Separate forward/backward plots. Separate forward/backward plots Feb 3, 2022
@calcmogul calcmogul merged commit 8e9448d into wpilibsuite:main Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange Analyzer graphs for Backward dataset
3 participants