Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Flex layout questions in 5.4.4 #1409

Open
thefrosty opened this issue Jul 8, 2021 · 1 comment
Open

CSS Flex layout questions in 5.4.4 #1409

thefrosty opened this issue Jul 8, 2021 · 1 comment

Comments

@thefrosty
Copy link

thefrosty commented Jul 8, 2021

Note, the following is just questions on CSS changes to flex and how they look in our install at the moment.

Issue Overview

Getting some odd formatting after change to flex layout change found here: b07658e#diff-1fc556f95754ee7e33d91044125c44bb9f750c99be4406756ffb27413adfcaf5R14

Steps to Reproduce (for bugs)

See attached screenshots of all fields now forced to 100%.

First screenshot shows a pencil edit icon that is hooked on 'rwmb_' . $field_type . '_html' (post and select_advanced).

Second screenshot shows were we also have notices that were formatted correct, but are forced right now (using rwmb_wrapper_html hook for after images notice)

Third screenshot show input fields now at 100% not honoring the size attribute, and a multi select (advanced) also at 100%.

Fourth shows how odd the Key/Value CSS change is.

Screen Shot 2021-07-07 at 12 57 38 PM

Screen Shot 2021-07-07 at 12 57 31 PM

Screen Shot 2021-07-08 at 8 21 25 AM

Screen Shot 2021-07-08 at 8 36 41 AM

@rilwis
Copy link
Member

rilwis commented Jul 9, 2021

Hi,

Thanks for your feedback.

The previous changes are actually 2 changes:

  1. Inputs are 100% width, and
  2. Use flexbox for fields

Can you let me know how did you hook in your 1st and 2nd problems?

For the 3rd problem, can you share the code of the fields? Basically, inputs will honor the size attribute.

I'll check the 4th problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants