Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromium-based Browsers: Export to png results in error #127

Closed
phr0 opened this issue Nov 18, 2022 · 1 comment · Fixed by #128
Closed

Chromium-based Browsers: Export to png results in error #127

phr0 opened this issue Nov 18, 2022 · 1 comment · Fixed by #128
Assignees
Labels
bug Something isn't working

Comments

@phr0
Copy link
Contributor

phr0 commented Nov 18, 2022

Describe the bug
Exporting a story as a png image results in an error being thrown and no png being exported, when using a chromium based browser.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://www.wps.de/modeler/index.html
  2. Click on the "Export story as SVG or PNG image, or animated HTML" button
  3. Click on "PNG"
  4. No download starts and an error message appears in the dev console
Uncaught TypeError: Cannot read properties of undefined (reading 'parentNode')
    at extractSVG (pngDownload.js:107:5)
    at downloadPNG (pngDownload.js:23:13)
    at HTMLButtonElement.<anonymous> (app.js:546:3)

Expected behavior
After clicking the "PNG" button a download of the exported story as a png image should start.

Screenshots
image

Tested with

  • Modeler Version: v1.3.2
  • Browser: Microsoft Edge Version 107.0.1418.42 and Google Chrome Version 107.0.5304.107
  • OS: Windows 10
@phr0
Copy link
Contributor Author

phr0 commented Nov 18, 2022

Seems to me like this is caused by this commit from over three years ago: e4403da. If I just revert these changes, the download works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants