Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid StCR settings migration when StCR is not installed #294

Closed
kristineds opened this issue Aug 14, 2016 · 3 comments
Closed

Avoid StCR settings migration when StCR is not installed #294

kristineds opened this issue Aug 14, 2016 · 3 comments
Assignees
@jaswrks
Labels
bug compatibility user experience
Milestone
v161213

Comments

@kristineds
Copy link
Contributor

kristineds commented Aug 14, 2016 •
edited

Quoted from this conversation with @raamdev:

In the event that Comment Mail detects that you're migrating from StCR, it tries to figure out which settings it should apply in Comment Mail by default (i.e., migrates your StCR settings to Comment Mail; see Subscribe to Comments Reloaded (StCR); Settings Imported by Comment Mail Upon Plugin Activation).

That said, it just occurred to me that we should probably avoid importing settings when the StCR plugin is not installed, even if we detect StCR settings in the database. That scenario would indicate the site owner is most likely not upgrading from StCR and won't expect settings to be migrated.
@raamdev raamdev added this to the Future Release milestone Aug 15, 2016
@raamdev raamdev modified the milestones: Next Release, Future Release Oct 11, 2016
jaswrks pushed a commit to wpsharks/comment-mail-pro that referenced this issue Dec 2, 2016
- **Bug Fix:** Do not attempt to import StCR settings if StCR is no l…
90c6e46 
…onger installed, even if old StCR options exist in the database. See [Issue #294](wpsharks/comment-mail#294).
@jaswrks jaswrks mentioned this issue Dec 2, 2016
Merged
@jaswrks
Copy link

jaswrks commented Dec 2, 2016

Next Release Changelog:

  • Bug Fix: Do not attempt to import StCR settings if StCR is no longer installed, even if old StCR options exist in the database. See Issue #294.

@renzms renzms mentioned this issue Dec 10, 2016
Closed
@renzms
Copy link
Contributor

renzms commented Dec 13, 2016

@jaswsinc @raamdev

Confirmed Working

Tested using Comment Mail Pro/Lite v161210-RC and StCR Version 160915 in WP v4.7

Steps taken

  • Installed StCR
  • Changed and saved some settings in StCR
  • Deactivated StCR, then uninstalled and Activated Comment Mail
  • There is no prompt for importing settings from StCR even if StCR settings are present in the database. 💯

raamdev added a commit that referenced this issue Dec 13, 2016
@raamdev
Phing release of v161213 with the following changes:
6573c2d 
- **Bug Fix:** Prevent browser autocomplete in Comment Mail options. See [Issue #319](#319).
- **Bug Fix:** Searching by email address alone should always narrow to the search to that specific email address and not result in any fuzzy or fulltext matching. See [Issue #226](#226).
- **Bug Fix:** The conflict check for 'Subscribe to Comments Reloaded' was not working in the previous release; i.e., if you attempt to activate both Comment Mail and the 'Subscribe to Comments Reloaded' plugin at the same, this should result in a Dashboard warning. Fixed in this release. See [Issue #315](#315).
- **Bug Fix:** Notify 'Subscribe to Comments Reloaded' users about the comment form template being disabled under certain scenarios. See [Issue #314](#314).
- **Bug Fix:** Do not attempt to import 'Subscribe to Comments Reloaded' (StCR) settings if StCR is no longer installed, even if old StCR options exist in the database. See [Issue #294](#294).
- **Bug Fix** (Pro): Do not show SparkPost partner image when Mandrill is selected as the RVE handler. See [Issue #318](#318).
- **Bug Fix** (Pro): Conflict checks between lite and pro corrected. This was not working properly in the previous release; i.e., installing Comment Mail Pro when Comment Mail Lite is already running should result in Comment Mail Lite being deactivated automatically. See [Issue #270](#270).
- **New Feature:** It is now possible to manually process the outgoing mail queue. See: **WP Dashboard → Comment Mail → Mail Queue**. See also [Issue #282](#282).
- **New Feature** (Pro): In Comment Mail Pro it is now possible to enable/disable comment content clipping entirely; e.g., if you prefer that email notifications include the full original comment content in raw HTML instead of being clipped and displayed in the email as plain text. See: **WP Dashboard → Comment Mail → Config. Options → Email Notification Clips**. See also: [Issue #281](#281).
- **Accessibility:** This release improves screen reader accessibility by adding `aria-hidden="true"` to all FontAwesome icons. See [Issue #304](#304).
- **Accessibility:** This release improves screen reader accessibility by offering a new setting that allows a site owner to enable or disable select menu option enhancement via jQuery. Disabling select menu option enhancement has the benefit of improving accessibility for screen readers whenever accessibility is of more concern than presentation. See: **Dashboard → Comment Mail → Config Options → Misc. UI-Related Settings**. See also [Issue #304](#304).
@raamdev
Copy link
Contributor

raamdev commented Dec 13, 2016

Comment Mail v161213 has been released and includes changes from this GitHub Issue. See the v161213 announcement for further details.

This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#294).

@raamdev raamdev closed this as completed Dec 13, 2016
@wpsharks wpsharks locked and limited conversation to collaborators Dec 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jaswrks jaswrks

Labels
bug compatibility user experience
Projects
None yet
Milestone
v161213
Development

No branches or pull requests
4 participants
@raamdev @jaswrks @kristineds @renzms