Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review/update the exercises #17

Open
JulieKuehl opened this issue Jun 2, 2019 · 1 comment
Open

Review/update the exercises #17

JulieKuehl opened this issue Jun 2, 2019 · 1 comment

Comments

@JulieKuehl
Copy link
Member

The exercises seem very detailed. Are they actual exercises? Do they fit the instructional strategy? Should be they part of the example lesson? Do they support the objectives?

A good set of exercises would be a chance to practice the information that was presented. And they would be the intermediate step that ties the objectives to the assessment.

Objectives -> instruction -> exercises -> assessment

@carlotrimarchi
Copy link

@Webwiese

The guide is a mix of basic and advanced CSS concepts. If someone doesn't know CSS at all, they won't be able to understand many instructions present in the guide. Since it probably requires lots of work and restructuring, together with @Webwiese we wrote ideas on how to do it. Eventually we should create small separate issues for each change and work on them individually.

The Hands-on Walkthrough section should be placed before the Exercises


Prerequisite skills

Besides basic HTML skills one should already know how to use the browser inspector, otherwise large part of this guide is focused on giving detailed instructions for how to change css properties in the browser. Maybe a dedicated guide or an external link to it would be better so here we can focus only on the css part


Materials needed

Using the Twenty Nineteen theme not Twenty Twelve


Additional resources

should we link to external resources, like the mdn basic css guide?
https://developer.mozilla.org/en-US/docs/Learn/Getting_started_with_the_web/CSS_basics


How to edit theme css the right way

It's mentioned that the right way to change CSS is using Jetpack. Is it really the simplest way to do it? Introducing a plugin just to work on basic styles seems a bit excessive and possibly confusing


Finding Your theme's styles

What's the point of this section?
It might be improved by showing some screenshots of how to use the browser inspector.
Explaining that you can use your browser to analyze and visualize your code and test changes before doing them.


[Between this section and the next there should be at least some explanation of where to write the CSS, because the document jumps from abstract descriptions to practical issues very fast]


How to target specific element in CSS?

Using IDs in css is not considered a good practice anymore, maybe we should only mention classes and elements?


Exercises

Restructure all the exercise in a way that they have a clear goal at the beginning, for example: "Change the font of the title element.", so that the user knows what he needs to accomplish and might attempt doing it before reading the solution

And then we add the solution in clear steps.

Exercise 1

In the css code shown there are css selectors used in cascade (like .entry-header .entry-title a ) but this way of doing it wasn't mentioned in the Hands on section

The exercise should be rewritten with simpler instructions, possibly in bullet points short sentences and more screenshots.
Current paragraphs are way too long

Exercise ideas:

  • Change font family on the blog title
  • Change font family for all paragraphs
  • Change font size on the blog title
  • Change font size for all paragraphs
  • Change background color for sticky posts
  • Add a pattern background for the whole page (using background and repeat) (at this level it's better and easier than the big image background and requires less knowledge)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants