Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Consider using an actual Wren testing library #123

Open
joshgoebel opened this issue Sep 22, 2021 · 0 comments
Open

RFC: Consider using an actual Wren testing library #123

joshgoebel opened this issue Sep 22, 2021 · 0 comments

Comments

@joshgoebel
Copy link
Contributor

The existing Python based testing is needlessly frustrating for simple Wren based logic testing, example:

https://github.com/joshgoebel/wren-console/blob/d1d8df30e9dc6f9844caf00a676a4ed944efa89e/test/io/file/basename.wren

There is no need for the entire output/redirection/verification process here. This could all be done 100% inside Wren with simple equality checking, etc... ie any of the existing Wren testing suites could be used. This also allows for MUCH nicer errors in cases of test failures.

My own wren-console project goes ahead and adds wren-testie for some of our newer functionality [regarding writing much more of the CLI in pure-Wren] (which I'm not sure will ever be upstreamed)... but now we'd also like to be able to use the simpler unit testing for some things that may get upstreamed (dirname, basename, etc), hence this issue being opened.

I of course naturally prefer wren-testie - and it would give me a good reason to ensure it continues to remain functional on both CLI and Console in the future, but really any nice Wren testing framework would be an improvement I think.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant