Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ghosted Plugins Sorted after the Bash Patch #164

Closed
Sharlikran opened this issue Oct 4, 2014 · 9 comments
Closed

Ghosted Plugins Sorted after the Bash Patch #164

Sharlikran opened this issue Oct 4, 2014 · 9 comments
Assignees
@Utumno
Labels
C-bug Category: Bug, an acknowledged defect in the program M-relnotes Misc: Issue should be listed in the version history for its milestone
Milestone
306

Comments

@Sharlikran
Copy link
Contributor

Revelant posts: WrinklyNinja felt this could be a possible bug here. Original post with steps to reproduce.

stickman1024's detailed steps to reproduce:

  1. I launched BOSS by clicking the shortcut on the toolbar of Wrye Bash
  2. In Bash ghosted plugins are sorted in alphabetically below active plugins.
     
    I repeated test case again, took more detailed notes, as in the forum post:
     
    Background:
     
  3. Uninstalled BOSS and deleted directory C:\BOSS
  4. Uninstalled LOOT
  5. Deleted %LOCALAPPDATA%\Skyrim\DLCList.txt, plugins.txt, loadorder.txt
  6. Downloaded and installed BOSS 2.3.0 from github
  7. Uninstalled all versions of Python, deleted directory C:\Python27
  8. Uninstalled all previous versions of Wrye Bash via uninstaller
  9. Verified all /Mopy directory are deleted
  10. Verified BashSettings.dat, Converters.dat, Installers.dat, Table.dat are deleted
  11. Downloaded Wrye.Bash.305.-.Installer.exe
  12. Installed Wrye Bash 305 standalone
  13. Plugins ghosted by previous Bash install are left as-is, all non-ghosted plugins are activated via Skyrim Launcher in Steam

Test (numbers are actions, sub-points are observations):

  1. Ran Wrye Bash 305:
    • auto-ghosting was disabled default on startup
    • active plugins sorted alphabetically (as sorted by Skyrim Launcher)
    • ghosted plugins sorted alphabetically below active plugins
    • when right click on BOSS shortcut in Bash, "BOSS disable lock load order" is checked, "Launch BOSS GUI" is unchecked.
       
  2. Lauched BOSS 2.3.0 from shortcut on Wrye Bash toolbar:
    • masterlist updated
    • BOSS completed sorting
    • BOSS log displayed in browser
    • loadorder.txt changed
       
  3. Refocused on Wrye Bash window 
    • no change in Mods tab plugin order
    • plugins still display as same order from 1b and 1c
    • did not reflect changes in loadorder.txt
       
  4. Quit Wrye Bash then ran Wrye Bash again immediately:
    • active (non-ghosted) plugins reflected order in loadorder.txt
    • ghosted plugins sorted alphabetically below active plugins - did not match loadorder.txt
@Sharlikran
Copy link
Contributor Author

@WrinklyNinja Can you look over this whenever you have time. Possibly at the same time you look into issue #162?

@Ortham Ortham self-assigned this Oct 4, 2014
@Ortham Ortham added this to the 306 milestone Oct 4, 2014
@Ortham Ortham added the C-bug Category: Bug, an acknowledged defect in the program label Oct 4, 2014
@Ortham
Copy link
Contributor

Ortham commented Oct 4, 2014

I can't replicate point 3, Bash refreshes on refocus fine for me.

However, I can replicate point 4, ghosted plugins are being moved to the bottom. Though I find that they're removed from loadorder.txt entirely.

@wrye-bash/active: Anyone know of any Skyrim plugins that I can upload to my repo without crossing some "no redistribution" clause? I just used my own plugins for Oblivion...

@Sharlikran
Copy link
Contributor Author

I have some patches where you need the original mod for the meshes and textures. As long as the file on the download tab does not say "Original Mod Not Required" then it should be a plugin only. You have my permission to use those.

Also I have full permissions for Val's Crafting Meltdown, Bandit EyePatch, and Bikini Clothes. Weapons of the Third Era gives permission to authors to use it. All the links are on my patches page.

@Sharlikran
Copy link
Contributor Author

I have not tried those steps but I don't have any issues with Bash refreshing on refocus either.

@Ortham
Copy link
Contributor

Ortham commented Oct 6, 2014

OK, I updated the bundled libloadorder to the new v6.0.0 release, and I'm still getting the ghosted plugins being moved.

Adding some debug logging to the Python code reveals that libloadorder is providing the correct load order output, so something must be going wrong after Bash gets those data.

@Ortham
Copy link
Contributor

Ortham commented Dec 15, 2014

@Sharlikran: I can no longer replicate this issue in my wrinklyninja-liblo-6-support branch, could you try it too?

@Sharlikran
Copy link
Contributor Author

I was testing the dev branch to provide Utumno with a tracelog from the dev branch. Two things happened. All my inactive plugins were automatically ghosted when I don't have the enabled and they were all sorted after the bash patch.

@wrye-bash/active I remember at one point Utumno had commented on a fix from wrinklyninja-liblo-6-support. IIRC there was an error. Was that resolved in commit 89d3fb5?

@Utumno
Copy link
Member

Utumno commented Jun 13, 2015

@Sharlikran: can you please try and reproduce this on my latest HEAD: ee68ccc

@Utumno Utumno mentioned this issue Jun 26, 2015
Closed
@Utumno Utumno closed this as completed in f5de6c8 Jul 17, 2015
Utumno added a commit that referenced this issue Jul 17, 2015
@Utumno
Bug in autoghost:
edca0c3 
Should relate to #164.
self.name = normal -> this would set the name to an absolute path !
in the case: mod is inactive and ghosted -> mod activated by liblo and
unghosted (works in liblo 6, didn't before) -> autoghost runs > finds
isGhost = True while 'normal' exists > Boom - see pics in #187.
Meaning all of a sudden self.name was an absolute path leading to all
kind of weirdness as the code expects it to be Yada.espm (relative to
Data/ dir) - FileInfo.name uses should be pruned as much as possible.
Set ghost now also sets ctime - this way running FileInfos.refresh()
two times in a row won't detect a change (it shouldn't in this case) -
I hope at least (modInfos refresh is my lovely little garden of bugs for
the last few months).
@Utumno Utumno assigned Utumno and unassigned Ortham Jul 17, 2015
@Utumno
Copy link
Member

Utumno commented Jul 17, 2015

Closing this as I can't reproduce it - see linked commits for the possible fixes - ghosting was a can of worms both in libloadorder and Bash

@Infernio Infernio added the M-relnotes Misc: Issue should be listed in the version history for its milestone label Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Utumno Utumno

Labels
C-bug Category: Bug, an acknowledged defect in the program M-relnotes Misc: Issue should be listed in the version history for its milestone
Projects
None yet
Milestone
306
Development

No branches or pull requests
4 participants
@Utumno @Sharlikran @Ortham @Infernio