Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybindings fire in textbox elements #1

Closed
wshanks opened this issue Sep 13, 2019 · 4 comments
Closed

Keybindings fire in textbox elements #1

wshanks opened this issue Sep 13, 2019 · 4 comments

Comments

@wshanks
Copy link
Owner

wshanks commented Sep 13, 2019

Mousetrap does not know about XUL elements that are not standard HTML, so it does not suppress itself inside of them.

@wshanks wshanks closed this as completed Sep 13, 2019
@ftoledo
Copy link

ftoledo commented Oct 25, 2019

can it be fixed?

@wshanks
Copy link
Owner Author

wshanks commented Oct 25, 2019

It is fixed for things that are actually the textbox class by 1ab9ee0. I have noticed that there are some other text input box elements for which key events still fire. In particular, events do not fire for me for composing emails or entering text in the search box, but they do fire for the quick search box. I want to fix the quick search box issue but I haven't had time to look into it. My workaround for now is to type my text in the regular search box, select and cut the text with ctrl+A, ctrl+X, and then paste the text into the quick search box.

Have you noticed other text boxes for which events fire?

@ftoledo
Copy link

ftoledo commented Oct 25, 2019

yes the quick search textbox and i found that the top rigth "search for addons " on the extension page also.

thanks!

@wshanks
Copy link
Owner Author

wshanks commented Oct 26, 2019

The previous commit fixed textbox elements and now b217506 fixes input elements like the quick search and addons search fields. I played around in the UI and didn't find any other types of text fields, so hopefully it is good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants