Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with getMembers() method in Groups #124

Closed
Captain-P-Goldfish opened this issue Jul 25, 2018 · 1 comment
Closed

problem with getMembers() method in Groups #124

Captain-P-Goldfish opened this issue Jul 25, 2018 · 1 comment

Comments

@Captain-P-Goldfish
Copy link
Contributor

RFC7643 describes the member attribute as follows

members
A list of members of the Group. While values MAY be added or
removed, sub-attributes of members are "immutable". The "value"
sub-attribute contains the value of an "id" attribute of a SCIM
resource, and the "$ref" sub-attribute must be the URI of a SCIM
resource such as a "User", or a "Group". The intention of the
"Group" type is to allow the service provider to support nested
groups. Service providers MAY require clients to provide a
non-empty value by setting the "required" attribute characteristic
of a sub-attribute of the "members" attribute in the "Group"
resource schema.

the problem in charon is that when the getMembers() method is called only a list with the values will be returned leaving the developer in the dark if the ID reference is another group, a user or any other resource.
It is possible to validate it by hand by using the method getAttributeList() but a helper sub-class in the groups class would be helpful here resolving the different values into member-objects.

@Captain-P-Goldfish
Copy link
Contributor Author

Captain-P-Goldfish commented Jul 25, 2018

just noticed that changing this would bring either a short unpleasant change into the library or some significant changes would have to be made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant