Casting patchOperation.getValues() to JSONObject causing class cast exception

[R-Zer0]

charon/modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/endpoints/GroupResourceManager.java

Line 697 in 5d5009c

if (!(patchOperation.getValues() instanceof String)) {

For the following patch operation I get operation value type as JSONArray.

{
      "op": "add",
      "path": "members",
      "value": [{
        "value": "23a35c27-23d3-4c03-b4c5-6443c09e7173",
        "display": "test.user@okta.local"
}

As result I get exception:

Caused by: java.lang.ClassCastException: org.json.JSONArray cannot be cast to org.json.JSONObject
at org.wso2.charon3.core.protocol.endpoints.GroupResourceManager.isDeleteAllUsersOperationFound(GroupResourceManager.java:698)
at org.wso2.charon3.core.protocol.endpoints.GroupResourceManager.updateWithPATCH(GroupResourceManager.java:653)

[R-Zer0]

I think it can be replaced with :

if (patchOperation.getValues() instanceof JSONObject) {

[cb-manideep]

@R-Zer0 I'm having the same issue. But I don't think that just checking would resolve the issue

if (patchOperation.getValues() instanceof JSONObject) {

I think it should be something like this:

private boolean isDeleteAllUsersOperationFound(List<PatchOperation> patchOperations) throws JSONException {

        for (PatchOperation patchOperation : patchOperations) {
            String operation = patchOperation.getOperation();
            String path = patchOperation.getPath();
            if (!(patchOperation.getValues() instanceof String)) {
                if (operation.equals(SCIMConstants.OperationalConstants.REPLACE)) {
                    if (path != null && path.equals(SCIMConstants.GroupSchemaConstants.MEMBERS)) {
                        return true;
                    } else if (patchOperation.getValues() instanceof JSONObject) {
                        JSONObject valuesJson = (JSONObject) patchOperation.getValues();
                        if (valuesJson.has(SCIMConstants.GroupSchemaConstants.MEMBERS)) {
                            return true;
                        }
                    }
                } else if (operation.equals(SCIMConstants.OperationalConstants.REMOVE) && path != null
                        && path.equals(SCIMConstants.GroupSchemaConstants.MEMBERS)) {
                    return true;
                }
            }
        }
        return false;
    }

Please let me know if this makes sense, I can raise a PR for this.