Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Checkstyle's breaking release versions 8.1 and 8.2 #8

Closed
wants to merge 1 commit into from

Conversation

thiloshon
Copy link

Purpose

Checkstyle had breaking releases (8.1 and 8.2) which made it impossible to use WSO2 config XML in new versions of Checkstyle. This PR contains fixes for two such issues which will enable using the config in newer versions of Checkstyle.

Resolves #4

Approach

Fix for breaking feature of Release 8.1

Making SuppressionCommentFilter and SuppressWithNearbyCommentFilter children of TreeWalker.
Refer:

  1. http://checkstyle.sourceforge.net/releasenotes.html#Release_8.1
  2. "SuppressionCommentFilter is not allowed as a child in Checker" jshiell/checkstyle-idea#341
  3. Make SuppressionCommentFilter and SuppressWithNearbyCommentFilter children of TreeWalker checkstyle/checkstyle#4714

Fix for breaking feature of Release 8.2

Removing FileContentsHolder module as FileContents object is available for filters on TreeWalker in TreeWalkerAudit Event

  1. http://checkstyle.sourceforge.net/releasenotes.html#Release_8.2
  2. remove FileContentsHolder module as FileContents object is available for filters on TreeWalker in TreeWalkerAudit Event  checkstyle/checkstyle#3573
  3. Cannot use checkstyle version 8.2: Unable to instantiate 'FileContentsHolder' class checkstyle/checkstyle#5132

@maheshika
Copy link
Contributor

staled

@maheshika maheshika closed this Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add checkstyle config in idea version 2017.2
2 participants