-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
@Path("/content") | ||
@Api(description = "The content API") | ||
|
||
public class ContentApi { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be MediaAPI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we discussed to change the url here: https://github.com/wso2/identity-media/pull/14/files/5b5f3e8dd45290d6c77d0f0d5bac9fdc4abf4afd#diff-b90f91dee8a28a753d932f644b3b9ba2R14
this would be the result of the auto-generation of code.
</configuration> | ||
</execution> | ||
</executions> | ||
<dependencies> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove unwanted dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this the recommended approach?
4th point given here: https://github.com/wso2/identity-api-server/blob/master/README.md
import javax.ws.rs.core.Response; | ||
|
||
|
||
public interface ContentApiService { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be MediaApiService?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
answered at: #14 (comment)
import org.wso2.carbon.identity.media.endpoint.ContentApiService; | ||
import org.wso2.carbon.identity.media.endpoint.impl.ContentApiServiceImpl; | ||
|
||
public class ContentApiServiceFactory { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to MediaApiServiceFactory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
answered at: #14 (comment)
|
||
private final static ContentApiService service = new ContentApiServiceImpl(); | ||
|
||
public static ContentApiService getContentApi() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to getMediaApi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
answered at: #14 (comment)
/** | ||
* Provides service implementation for downloading protected media. | ||
*/ | ||
public class ContentApiServiceImpl implements ContentApiService { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to media..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
answered at: #14 (comment)
@@ -0,0 +1,525 @@ | |||
openapi: 3.0.0 | |||
info: | |||
version: 'v1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make the version defined here consistent with the version in the url
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed with:9030bd1
Issue: wso2/product-is#8499