Skip to content
This repository has been archived by the owner on Apr 21, 2024. It is now read-only.

Add media service API. #14

Merged
merged 3 commits into from
Jun 24, 2020
Merged

Conversation

dewniMW
Copy link
Contributor

@dewniMW dewniMW commented Jun 24, 2020

@Path("/content")
@Api(description = "The content API")

public class ContentApi {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be MediaAPI?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we discussed to change the url here: https://github.com/wso2/identity-media/pull/14/files/5b5f3e8dd45290d6c77d0f0d5bac9fdc4abf4afd#diff-b90f91dee8a28a753d932f644b3b9ba2R14
this would be the result of the auto-generation of code.

</configuration>
</execution>
</executions>
<dependencies>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unwanted dependency

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this the recommended approach?
4th point given here: https://github.com/wso2/identity-api-server/blob/master/README.md

import javax.ws.rs.core.Response;


public interface ContentApiService {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be MediaApiService?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

answered at: #14 (comment)

import org.wso2.carbon.identity.media.endpoint.ContentApiService;
import org.wso2.carbon.identity.media.endpoint.impl.ContentApiServiceImpl;

public class ContentApiServiceFactory {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to MediaApiServiceFactory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

answered at: #14 (comment)


private final static ContentApiService service = new ContentApiServiceImpl();

public static ContentApiService getContentApi()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to getMediaApi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

answered at: #14 (comment)

/**
* Provides service implementation for downloading protected media.
*/
public class ContentApiServiceImpl implements ContentApiService {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to media..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

answered at: #14 (comment)

@@ -0,0 +1,525 @@
openapi: 3.0.0
info:
version: 'v1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make the version defined here consistent with the version in the url

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed with:9030bd1

@emswbandara emswbandara merged commit 78af2c0 into wso2-attic:master Jun 24, 2020
wso2-jenkins-bot added a commit that referenced this pull request Jul 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants