This repository has been archived by the owner on Apr 21, 2024. It is now read-only.
Add media download operation. #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emswbandara
reviewed
Jun 29, 2020
| */ | ||
| public RealmService getRealmService() { | ||
|
|
||
| return MediaEndpointDataHolder.getInstance().realmService; |
There was a problem hiding this comment.
no need to calll MediaEndpointDataHolder.getInstance() here.. we can directly return realmService
emswbandara
reviewed
Jun 29, 2020
| */ | ||
| public void setRealmService(RealmService realmService) { | ||
|
|
||
| MediaEndpointDataHolder.getInstance().realmService = realmService; |
There was a problem hiding this comment.
change to this.realmService = realmService
emswbandara
reviewed
Jun 29, 2020
...rc/main/java/org/wso2/carbon/identity/media/endpoint/common/factory/RealmServiceFactory.java
Outdated
Show resolved
Hide resolved
emswbandara
reviewed
Jun 29, 2020
...dia.endpoint/src/main/java/org/wso2/carbon/identity/media/endpoint/service/MediaService.java
Outdated
Show resolved
Hide resolved
emswbandara
reviewed
Jun 29, 2020
| * @param identifier File identifier. | ||
| * @return requested media file. | ||
| */ | ||
| public Response downloadMediaFile(String type, String id, String identifier) { |
There was a problem hiding this comment.
shall we add validation for type also? what will happen if type is null?
There was a problem hiding this comment.
emswbandara
reviewed
Jun 30, 2020
...nt/src/main/java/org/wso2/carbon/identity/media/endpoint/common/MediaEndpointDataHolder.java
Outdated
Show resolved
Hide resolved
emswbandara
reviewed
Jun 30, 2020
| @@ -48,7 +48,7 @@ public Response privilegedUserListMediaInformation(String type, String id) { | |||
| public Response privilegedUserUploadMedia(String type, List<InputStream> filesInputStream, | |||
| List<Attachment> filesDetail, PrivilegedUserMetadata metadata) { | |||
|
|
|||
| mediaService.validateMediaType(type, filesDetail.get(0).getContentType()); | |||
| mediaService.validateAllowedMediaTypesForUploading(type, filesDetail.get(0).getContentType()); | |||
There was a problem hiding this comment.
shall we change the method name to, validateFileUploadMediaTypes or something similar?
emswbandara
approved these changes
Jul 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: wso2/product-is#8499