Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Consider switching from Partridge to GTFS_Kit #266

Closed
4 tasks done
e-lo opened this issue Apr 6, 2021 · 2 comments
Closed
4 tasks done

[FEATURE] Consider switching from Partridge to GTFS_Kit #266

e-lo opened this issue Apr 6, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@e-lo
Copy link
Collaborator

e-lo commented Apr 6, 2021

User Story

As a developer I'd like to use as many existing and up-to-date libraries as possible to do GTFS validation

Status

  • Defined
  • Planned
  • Implemented
  • Tested

Priority

Low

Level of Effort

Moderate

Resolution Ideas

https://github.com/mrcagney/gtfs_kit/tree/master/gtfs_kit

Project

Is there a funder or project associated with this feature?
No

Who should be involved?

Implementer:
Commenters:
Users:
Reviewers:

Risk

Will this potentially break anything?
Yes

Tests

What are relevant tests or what tests need to be created in order to determine that this issue is complete?
All

@e-lo e-lo added the enhancement New feature or request label Apr 6, 2021
@e-lo e-lo self-assigned this Apr 15, 2024
@e-lo e-lo added this to the v1.0 milestone Apr 15, 2024
@e-lo
Copy link
Collaborator Author

e-lo commented Apr 15, 2024

Resolved by removing partridge as dependency and encapsulating functionality in Feed module and GTFS data model

e-lo added a commit that referenced this issue Apr 16, 2024
Create base set of types and classes implemented in pandera and pydantic to efficiently validate GTFS and network data and foreign keys.

Fixes #266, #344 #123, and #345
@e-lo
Copy link
Collaborator Author

e-lo commented Aug 27, 2024

Implemented our own models, so moot for now.

@e-lo e-lo closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant