Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Roadway Data Model #344

Closed
2 tasks done
e-lo opened this issue Apr 16, 2024 · 1 comment
Closed
2 tasks done

[FEATURE] Roadway Data Model #344

e-lo opened this issue Apr 16, 2024 · 1 comment
Assignees
@e-lo
Labels
enhancement New feature or request
Milestone
v1.0

Comments

@e-lo
Copy link
Collaborator

e-lo commented Apr 16, 2024 •
edited
Loading

User Story

As a user, I'd like to understand what the data model is for roadway networks and get clear error messages when my data does not comply with them.

As a developer, I want to be able to rely on data conforming to a specific data model throughout network_wrangler without having to test it each time

Priority

High

Level of Effort

Med-High

Resolution

  • Leverage pydantic for complex types and individual records
  • Leverage pandera for dataframe validation/schemas because it is much faster for multiple records

Tests

Tested in tests/test_models
@e-lo e-lo added the enhancement New feature or request label Apr 16, 2024
@e-lo e-lo self-assigned this Apr 16, 2024
@e-lo e-lo added this to the v1.0 milestone Apr 16, 2024
e-lo added a commit that referenced this issue Apr 16, 2024
@e-lo
Implement roadway and transit data models.
aa18ffe 
Create base set of types and classes implemented in pandera and pydantic to efficiently validate GTFS and network data and foreign keys.

Fixes #266, #344 #123, and #345
@e-lo
Copy link
Collaborator Author

e-lo commented Jul 17, 2024

Fixed in selection-refactor branch and released in v1.0-alpha.1

@e-lo e-lo closed this as completed Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e-lo e-lo

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
1 participant
@e-lo