Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Return default value in get_property_by_time_period_and_group. #292

Closed
4 tasks done
e-lo opened this issue Apr 19, 2022 · 0 comments · Fixed by #327
Closed
4 tasks done

[Feature] Return default value in get_property_by_time_period_and_group. #292

e-lo opened this issue Apr 19, 2022 · 0 comments · Fixed by #327
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@e-lo
Copy link
Collaborator

e-lo commented Apr 19, 2022

RoadwayNetwork.get_property_by_time_period_and_group() should allow the return something explicit if it isn't found.

Status

  • Defined
  • Planned
  • Implemented
  • Tested
if prop not in list(self.links_df.columns):
            WranglerLogger.warning(
                "Property {} not in links to split, returning as default value: {}".format(
                    prop, default_return
                )
            )
            return pd.Series([default_return] * len(self.links_df))
@e-lo e-lo added the enhancement New feature or request label Apr 19, 2022
@e-lo e-lo added this to the v1.0 milestone Apr 19, 2022
@e-lo e-lo self-assigned this Apr 19, 2022
@e-lo e-lo changed the title [Feature] Return value if not [Feature] Return default value in get_property_by_time_period_and_group. Apr 19, 2022
@e-lo e-lo linked a pull request Apr 15, 2024 that will close this issue
@e-lo e-lo closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant