Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Consistency in Naming link/links and node/nodes #307

Closed
4 tasks done
e-lo opened this issue Nov 29, 2022 · 1 comment · Fixed by #327
Closed
4 tasks done

[FEATURE] Consistency in Naming link/links and node/nodes #307

e-lo opened this issue Nov 29, 2022 · 1 comment · Fixed by #327
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@e-lo
Copy link
Collaborator

e-lo commented Nov 29, 2022

User Story

As a user and developer I'd like to use consistent terms throughout the network wrangler API, including node vs nodes and link vs links

Status

  • Defined
  • Planned
  • Implemented
  • Tested

Context

Right now project cards use link and node to describe a facility selection but links and nodes to describe new or deleted links.

Resolution Ideas

Since it is more accurate to describe these as plural lists, consistently implement links and nodes throughout the API and data spec.

Priority

Medium

Level of Effort

Low (already done)

@e-lo e-lo added the enhancement New feature or request label Nov 29, 2022
@e-lo e-lo added this to the v1.0 milestone Nov 29, 2022
@e-lo e-lo self-assigned this Nov 29, 2022
@e-lo e-lo linked a pull request Apr 15, 2024 that will close this issue
@e-lo
Copy link
Collaborator Author

e-lo commented Jul 17, 2024

Fixed in #327

@e-lo e-lo closed this as completed Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant