Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in macav2 ea calculation #1

Closed
cpearson1 opened this issue Jun 8, 2020 · 1 comment
Closed

error in macav2 ea calculation #1

cpearson1 opened this issue Jun 8, 2020 · 1 comment

Comments

@cpearson1
Copy link
Contributor

cpearson1 commented Jun 8, 2020

~Line: 351
#estimate sat. vapor press and use vpd
es = 0.6108np.exp(17.27self.data.tavg_c/(self.data.tavg_c+237.3))
self.data['ea_kpa'] = self.data.vapor_pres_def + es
***VPD = es - ea; ea_kpa calc is incorrect

Calculation should follow ASCE standardized refet Table 3 Preferred Procedure Order:
https://www.uidaho.edu/-/media/UIdaho-Responsive/Files/cals/centers/Kimberly/water-resources/ASCE-Standardized-Reference-Evapotranspiration-Equation-draft-report-without-appendices.pdf?la=en&hash=F4E3EB1290A7971E172F23A2A3B660B237D727D0

Proposed Fix (use maca provided specific humidity):
if product == 'macav2':
self.data['wind_mean'] = np.sqrt(
self.data['eastward_wind']**2 + self.data['northward_wind']**2
)
self.data['pa'] = np.full(length, refet.calcs._air_pressure(elev))
self.data['ea_kpa'] = refet.calcs._actual_vapor_pressure(
self.data.specific_humidity, self.data.pa
)

cpearson1 added a commit that referenced this issue Jun 8, 2020
@jhuntington
Copy link

jhuntington commented Jun 8, 2020 via email

JohnVolk added a commit that referenced this issue Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants