Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitute .splups files for .scups files in functions for older versions of the database #280

Open
jwreep opened this issue Apr 30, 2024 · 2 comments
Labels
compatibility Issues related to compatibility with past/future versions of the database database effort-high Ion Anything related to the Ion object

Comments

@jwreep
Copy link
Collaborator

jwreep commented Apr 30, 2024

#17 had a note that the files will need to be substituted in any function that makes use of .scups datafiles. The tests would need to be suitably modified as well.

@wtbarnes
Copy link
Owner

wtbarnes commented May 1, 2024

I wonder if we should have some higher-level object that exposes the information provided by these files. I'd like to avoid having to deal with if splups exists logic all over the codebase as I imagine it would become very messy very quickly.

I'm just thinking aloud here, but we could have some sort of additional attribute _upsilon_data attribute that prioritizes one versus the other. We may need to abstract away how the spline fitting is done as well. I'm not exactly sure how similar these two darasets are.

@jwreep
Copy link
Collaborator Author

jwreep commented May 1, 2024

That's probably the way to go. Considering #11 and #235, this might be a good time to think of how to generalize all the data input. If one wanted to use atomdb's data to calculate level populations, for example, what modification would the code need?

@wtbarnes wtbarnes added database effort-high Ion Anything related to the Ion object compatibility Issues related to compatibility with past/future versions of the database labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Issues related to compatibility with past/future versions of the database database effort-high Ion Anything related to the Ion object
Projects
None yet
Development

No branches or pull requests

2 participants