Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighted background row seems to spill over #1280

Closed
zyrre opened this issue Jul 20, 2022 · 3 comments
Closed

Highlighted background row seems to spill over #1280

zyrre opened this issue Jul 20, 2022 · 3 comments
Assignees
Labels

Comments

@zyrre
Copy link
Contributor

zyrre commented Jul 20, 2022

Whenever a row is highlighted it seems that all following rows receive the HighlightedBackground color?
To illustrate, here I have row 5 highlighted:
image

There is no difference among modules, all that have row highlighting act the same.

Any idea what can cause this?

For info: I just cloned the repo and built it, ran bin/wtfutil.
Also, adding something like
colors: background: red
to the config will change the background color, but adding this:
colors: highlight: fore: red back: red
does not change any of the colors.

@Seanstoppable Seanstoppable self-assigned this Aug 14, 2022
@Seanstoppable
Copy link
Collaborator

Seanstoppable commented Aug 14, 2022

Definately a regression.

Using git bisect, I've narrowed it down to the following. Unfortunately compile errors mean on most of these mean that I couldn't get a clean exact commit.
e72dcda (changes to highlight and textwidget)
d3357e9 (probably not, as gitlab update)
9bba717 (Upgrade to tcell2, seems possible)
d7ccba4 (Golang ci change, so unlikely)
4ef88b4 (Godo upgrade, so unlikely)
bb31254 (Go-pretty upgrade, which also seems possible culprit). Verified not culprit

Will dig in more.

@senorprogrammer
Copy link
Collaborator

Nice find, I'm pretty sure it's the result of the cell upgrade. It seems a lot changed under the hood with /v2.

@senorprogrammer
Copy link
Collaborator

Fixed with #1300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants