Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix on URL links in 'brunch' #2

Closed
nc6 opened this issue Apr 18, 2013 · 4 comments
Closed

Prefix on URL links in 'brunch' #2

nc6 opened this issue Apr 18, 2013 · 4 comments
Assignees

Comments

@nc6
Copy link
Collaborator

nc6 commented Apr 18, 2013

Brunch currently assumes it's running in a web root of '/'.

@jrandall
Copy link
Contributor

This actually appears to have been a minor issue with accidentally having some hardcoded links to (e.g.) "../img/foo.jpg" when actually we were already at the root level (so it resolved to "img/foo.jpg" when running out of / and worked fine, but when we put the site under "/bar/" it ended up resolving to "/img/foo.jpg" instead of "/bar/img/foo.jpg".

Chaplin seems to be working correctly when installed under a subdirectory, so we should be able to accomplish this by keeping everything relative as Nick suggests.

@ghost ghost assigned jrandall Apr 18, 2013
@jrandall
Copy link
Contributor

Fixed by 2eecb48

@jrandall
Copy link
Contributor

Actually, no, the static assets are fixed but dynamic templates are not running on pages when installed in other than '/'

@jrandall jrandall reopened this Apr 20, 2013
@jrandall
Copy link
Contributor

Fixed in 59ff88c

Now need to set baseUri in settings.coffee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants