Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AEM build with same Java as set for instance #126

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

krystian-panek-vmltech
Copy link
Contributor

fixes #125

@@ -243,9 +243,9 @@ func (c *CLI) printCommandResult() {
func (c *CLI) printDataValue() {
value, ok := c.outputResponse.Data[c.outputValue]
if !ok {
println("<undefined>")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is nasty;

it writes to both STDOUT and STDERR

then in bash scripts value captured from subshell needs to be redirected

@@ -243,9 +243,9 @@ func (c *CLI) printCommandResult() {
func (c *CLI) printDataValue() {
value, ok := c.outputResponse.Data[c.outputValue]
if !ok {
println("<undefined>")
fmt.Println("<undefined>")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this writes only to STDOUT as expected

@krystian-panek-vmltech krystian-panek-vmltech merged commit cc77dd4 into main Apr 27, 2023
@krystian-panek-vmltech krystian-panek-vmltech deleted the aem-build-with-same-java branch April 27, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instruct Maven build to reuse downloaded JDK
1 participant