Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique screen name validation #576

Merged
merged 5 commits into from
Feb 15, 2021
Merged

Conversation

geislerm
Copy link
Collaborator

@geislerm geislerm commented Sep 15, 2020

Description, Motivation and Context

Duplicated screen collector name was causing IllegalArgumentException during test run and no information was returned to the user. As the screen collector name needs to be unique - additional validation has been added.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have reviewed (and updated if needed) the documentation regarding this change

I hereby agree to the terms of the AET Contributor License Agreement.

@geislerm geislerm linked an issue Sep 15, 2020 that may be closed by this pull request
@tMaxx tMaxx force-pushed the feature/unique-screen-name-validation branch from 7477450 to a19ea7b Compare February 15, 2021 14:22
@tMaxx tMaxx merged commit 6c29eab into master Feb 15, 2021
@tMaxx tMaxx deleted the feature/unique-screen-name-validation branch February 15, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicated screen name parameter causes infinity loader.
2 participants