Skip to content
This repository has been archived by the owner on Nov 23, 2021. It is now read-only.

Code cleanup - mark features which will be abandoned with @Deprecated #228

Closed
10 tasks done
Shaihuludus opened this issue Mar 8, 2018 · 5 comments
Closed
10 tasks done
Assignees
Labels
migration notes Contains migration notes
Milestone

Comments

@Shaihuludus
Copy link
Collaborator

Shaihuludus commented Mar 8, 2018

Review the codebase and mark with @Deprecated functionality that will be removed.

  • Core
  • Annotations
  • JUnit
  • Email
  • Reports
  • Traffic
  • Cucumber
  • AEM Common
  • AEM ClassicUI
  • AEM TouchUI
@mkrzyzanowski mkrzyzanowski added this to the 2.0#2 milestone May 16, 2018
@mkrzyzanowski mkrzyzanowski changed the title Mark feature which will be abandoned with Deprecated Code cleanup - mark features which will be abandoned with @Deprecated May 16, 2018
@mkrzyzanowski
Copy link
Contributor

mkrzyzanowski commented Aug 3, 2018

Core module

@mkrzyzanowski
Copy link
Contributor

Per #244, deprecate JUnit and Reports modules & update the documentation accordingly.

@mkrzyzanowski
Copy link
Contributor

mkrzyzanowski commented Sep 12, 2018

Deprecations:

  • bb-junit module
  • bb-reports module
    • com.cognifide.qa.bb.reporter.Reporter annotation from core module
  • bb-aem-common module
  • bb-aem-classic module
  • bb-aem-touch-ui module
  • com.cognifide.qa.bb.qualifier.Retry and whole retry mechanism (goes away with bb-junit)
  • com.cognifide.qa.bb.config.LegacyConfig - will be replaced totally with YamlConfig
    • Bobcat switched to YAML config by default; to continue using the Legacy properties-based one, users now need to run tests with bobcat.config=legacy System property
  • com.cognifide.qa.bb.assertions.soft - we recommend using AssertJ's SoftAssertions
  • com.cognifide.qa.bb.loadable - #228 Loadable package and module deprecated #266

mkrzyzanowski added a commit that referenced this issue Sep 12, 2018
mkrzyzanowski added a commit that referenced this issue Sep 18, 2018
#228 Loadable package and module deprecated
@mkrzyzanowski
Copy link
Contributor

mkrzyzanowski commented Sep 18, 2018

Additional items for further cleanup:

  • BobcatWait/Conditions/WebElementUtils rework: providing a single utility
  • WebDriverType - move the proxy cookie to a modifier/remove it totally
  • PageObjectInjector - add support for injections of PageObjects with locators in annotation
    • this is not trivial - this helper already takes part in PageObject construction

@mkrzyzanowski
Copy link
Contributor

Released in 1.6.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
migration notes Contains migration notes
Projects
None yet
Development

No branches or pull requests

2 participants