Skip to content
This repository has been archived by the owner on Nov 23, 2021. It is now read-only.

288 bobcatwait reworked #291

Merged
merged 11 commits into from
Oct 3, 2018
Merged

288 bobcatwait reworked #291

merged 11 commits into from
Oct 3, 2018

Conversation

mkrzyzanowski
Copy link
Contributor

@mkrzyzanowski mkrzyzanowski commented Oct 1, 2018

Description

This PR deprecates the 'old' BobcatWait and introduces a reworked one that combines functionality from Conditions.

Motivation and Context

#228

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code styleguide of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@mkrzyzanowski
Copy link
Contributor Author

Changelog:

  • com.cognifide.qa.bb.provider.selenium.BobcatWait is now deprecated - use com.cognifide.qa.bb.wait.BobcatWait instead
    • part of the API is not available in the new reworked version, new options are available though - see the documentation
  • expected conditions from com.cognifide.qa.bb.expectedconditions are deprecated - use the official WebDriver ExpectedConditions or the newly introduced WebElementConditions

@mkrzyzanowski mkrzyzanowski merged commit ef63f2f into master Oct 3, 2018
@mkrzyzanowski mkrzyzanowski deleted the 288-bobcatwait-reworked branch October 3, 2018 14:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants