Skip to content
This repository has been archived by the owner on Mar 2, 2022. It is now read-only.

Supporting relative path #12

Closed
wants to merge 13 commits into from
Closed

Conversation

fyc1007261
Copy link

(I have separated the file system modification. I'm terribly sorry that I might not be able to merge all commits into one. I have some other modifications to the kernel that I have commited to my own fork. And the new branch I created today is based on my current master, which already has a lot of old commits, it might be too late for me to merge them into one. Can you select the "squash and merge" option if you would like to accept the PR. That may merge all my all commits into one. Thanks!)

  • Support relative path in file system (might contain some concurrency bugs as locks for file systems in tasks are not implemented).
  • Add syscall chdir.
  • Modify some system calls such as getcwd, open and access. Let them check whether the user is entering a relative path or absolute path then do the corresponding operations.

fyc1007261 and others added 13 commits July 22, 2019 13:36
branch 'postgres'

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
* try

* to merge

* clean merge
@lastweek
Copy link
Contributor

Hi @fyc1007261, it's alright! I'll review the code and merge them. However, I will merge some of your commits into one. Again, thank you for your contribution.

@fyc1007261
Copy link
Author

Hi @fyc1007261, it's alright! I'll review the code and merge them. However, I will merge some of your commits into one. Again, thank you for your contribution.

It's the first time that I try to contribute to a large open source project. I'm really sorry that it may cause you some trouble.

@lastweek
Copy link
Contributor

Hi @fyc1007261, it's alright! I'll review the code and merge them. However, I will merge some of your commits into one. Again, thank you for your contribution.

It's the first time that I try to contribute to a large open source project. I'm really sorry that it may cause you some trouble.

Hey @fyc1007261 , no worries. Everyone starts from there. It's good you made your first attempt! Besides, I'm just a little (some say extremely :p) picky about code qualify, even for indentation.

Anyway, even if you are doing your own hacking of a kernel, it's suggested to maintain a clean commit history so you know what has been changed by checking commit messages. You can do rebase regularly on your own dev branch (sometimes I got lost from my own random commits).

@fyc1007261
Copy link
Author

I found that my current implementation contains some bugs. I'll try to fix it first.

@fyc1007261 fyc1007261 closed this Oct 5, 2019
@fyc1007261 fyc1007261 deleted the relative_path branch October 8, 2019 00:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants