Updates to microphone permissions and plugins #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still get this issue when I first download/install the packaged version... might be related to electron/electron#20498 I tried wrapping all the calls in try/catch and getting an error dialog, but it still crashes with no message, so I'm guessing it has to do with something internal to electron |
|
Update, the issue we were having was this: electron/electron#19307 Adding the extra entry in the entitlements did the trick for me. Waiting for others to test, to make sure it worked Also lol removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #760
Not sure what was causing it, but I've added a lot of checks and safeguards around microphone permissions and usage. I was able to reproduce locally and now I can't. I'll also ping people to test the packaged version.
Also tries to fix the issues with the plugins. Turns out if you
npm pruneit removes all of the node_modules, so Kap can't actually require the plugins. Yarn's docs say thatyarn installwill automatically prune extra dependencies, so I've replaced the prune with that. (also removing npm as a dependency).