Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile for BLAST 2.15.0 #743

Merged
merged 1 commit into from
May 29, 2024

Conversation

nathanweeks
Copy link
Contributor

SequenceServer 3.0.1 supports BLAST 2.15.0, though the Dockerfile currently specifies 2.14.0:

ARG BLAST_VERSION=2.14.0

This PR proposes updating the Dockerfile for BLAST 2.15.0, with several other ancillary modifications:

  • Facilitate arm64 container builds by using ncbi/blast-static (which has linux/arm64 images)
  • Use ruby "bookworm" base images instead of "bullseye" to fix resulting GLIBCXX_<version> not found errors
  • While devops best practices generally involve pinning dependencies as precisely as possible for reproducibility, suggest not pinning ruby patch version (i.e., (ruby:3.2 instead of ruby:3.2.<patch>) so newer/patched versions are more easily/likely used during development & production builds
  • Update node base image from (EOL) version 15 to (LTS) version 20.
  • Explicitly specify container registry for build environments where docker.io is not the default

@yannickwurm yannickwurm requested a review from tadast May 27, 2024 16:45
Copy link
Collaborator

@tadast tadast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @nathanweeks 🙌

@yannickwurm yannickwurm merged commit e84332b into wurmlab:master May 29, 2024
4 checks passed
@nathanweeks nathanweeks deleted the docker-2.15.0 branch May 29, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants