Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardise output of baggr_compare #29

Closed
wwiecek opened this issue Oct 23, 2019 · 5 comments
Closed

Standardise output of baggr_compare #29

wwiecek opened this issue Oct 23, 2019 · 5 comments
Assignees
@wwiecek
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@wwiecek
Copy link
Owner

wwiecek commented Oct 23, 2019

Currently it's a mix of print within the function (bad!), ggplot output and numerical output.
We definitely need to have a print.baggr_compare S3, perhaps also plotting method. The output should be minimal.
@wwiecek wwiecek added the enhancement New feature or request label Oct 23, 2019
@wwiecek wwiecek added this to the v0.3 release milestone Oct 23, 2019
@wwiecek wwiecek self-assigned this Oct 23, 2019
@wwiecek wwiecek modified the milestones: v0.3 release, v0.2.1 Nov 18, 2019
@wwiecek
Copy link
Owner Author

wwiecek commented Nov 18, 2019

@be-green this is one potential PR we discussed!

@be-green
Copy link
Contributor

I can have a PR for this in the next day or two.

@wwiecek wwiecek added the good first issue Good for newcomers label Dec 13, 2019
@wwiecek wwiecek mentioned this issue Dec 13, 2019
Closed
@be-green
Copy link
Contributor

be-green commented Jan 1, 2020

This is almost ready, but I need to include the change in display of hypermeans and add additional tests. Hopefully done in the next day or so.

@wwiecek
Copy link
Owner Author

wwiecek commented Jan 2, 2020

Cool. Sorry if stating the obvious OR if saying this too late, but baggr_plot has hyper argument, maybe this can be the same in baggr_compare? Good if the two functions were harmonised in some sense.

@wwiecek wwiecek removed this from the v0.2.1 milestone Feb 13, 2020
@wwiecek
Copy link
Owner Author

wwiecek commented Feb 21, 2020

This is now done and can be closed. There is a couple of bugs relating to it in separate issues.

@wwiecek wwiecek closed this as completed Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wwiecek wwiecek

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wwiecek @be-green