Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to save cluster representative #3

Closed
apcamargo opened this issue Mar 3, 2020 · 5 comments
Closed

Option to save cluster representative #3

apcamargo opened this issue Mar 3, 2020 · 5 comments

Comments

@apcamargo
Copy link
Contributor

An option to save cluster representatives to an output directory would simplify most dereplication pipelines. Currently, if the user wants to get the FASTA files of the dereplicated genomes it need to first parse galah's output and then move/copy the representative genomes to the desired location.

@wwood wwood closed this as completed in d7c34fc Mar 4, 2020
@apcamargo
Copy link
Contributor Author

Thanks!

@wwood
Copy link
Owner

wwood commented Mar 4, 2020

Hi,

I've added an option --output-representative-fasta-directory for this (which makes symlinks to absolute paths) and also --output-representative-list for just a list of the reps. I'm not 100% convinced about symlinking rather than copying, just trying to be nice to all the sysadmins out there.

Also now there is no stdout by default - an output mode must be chosen.

Let me know if there's anything else.

@apcamargo
Copy link
Contributor Author

As a user, I'd feel safer if the files were copied. A typical pipeline for a disk-constrained environment would be:

Bin each sample -> Dereplicate bins from all samples and save them to a directory -> Delete invidivual-sample bins

@wwood wwood reopened this May 1, 2020
@wwood wwood closed this as completed in bf70a16 May 1, 2020
@wwood
Copy link
Owner

wwood commented May 1, 2020

Hi,

I've added that functionality with by adding --output-representative-fasta-directory-copy now. Thanks again for the suggestion.

@apcamargo
Copy link
Contributor Author

Thanks Ben!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants